Render typed managed auth errors - #27
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
akxue
requested changes
Aug 31, 2026
akxue
left a comment
There was a problem hiding this comment.
reviewed — looks good overall, one blocking copy change:
Blocking
packages/managed-auth-react/src/components/StepError.tsx:44-48— "Additional customer input is required" reads as internal jargon to the end user seeing this error screen. Suggest "Additional information is required before login can continue." to keep it clean.
Nits
packages/managed-auth-react/src/components/StepError.test.tsx:27—not.toEqual(errorDisplayForCode("credentials_invalid"))would also pass ifcredentials_invalidwere missing from the map (bothundefined); a truthiness assert on it would pin the distinction more tightly.
akxue
approved these changes
Sep 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
dependency
kernel/kernel#3666 is merged and deployed. The component remains backward-compatible because unknown and older codes retain their current fallback behavior.
validation
bun testbun run typecheckbun run format:checkbun run buildNote
Low Risk
UI-only error messaging in the managed-auth React package; unknown error codes keep prior fallback behavior.
Overview
StepErrornow maps new managed-autherrorCodevalues to dedicated titles and descriptions instead of falling back to generic error copy.Adds display entries for MFA/challenge blockers (
totp_required,sms_code_required,email_code_required,account_choice_required,customer_input_required,external_action_required) with context-neutral wording, plustotp_code_rejectedwith recovery guidance that is separate fromcredentials_invalid.Exports
errorDisplayForCodefor lookup and wiresStepErrorthrough it; unknown codes still use the existing localized fallback. Includes unit tests for the new copy and a patch changeset for@onkernel/managed-auth-react.Reviewed by Cursor Bugbot for commit 35469c1. Bugbot is set up for automated code reviews on this repo. Configure here.